This makes gitlabhq compatible with more LDAP servers (specifically OpenLDAP). #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with compatibility with more LDAP providers as the implementation doesn't depend on the exact names of the LDAP fields. The LDAP strategy helps maps the attributes to the fields in the info object and we use the info object to get the email and name. This makes the LDAP auth compatible with most OpenLDAP servers as well.
|
are you sure in your code. It tested? |
|
Yes. Tested against an OpenLDAP server and an Active Directory server. Works on both. Previously, authenticating against our internal OpenLDAP server was failing because our ldap entries don't have the sAMAccountName attribute defined causing an exception at user.rb:71. Getting these attributes is abstracted by the omniauth-ldap strategy to simplify supporting more LDAP servers. In omniauth/strategies/ldap.rb, look at how it maps the attributes to the info object with the @@config map and map_user(). https://github.com/intridea/omniauth-ldap/blob/master/lib/omniauth/strategies/ldap.rb |
|
@vsizov you did ldap - merge it if ok |
vsizov
added a commit
that referenced
this pull request
Feb 19, 2012
This makes gitlabhq compatible with more LDAP servers (specifically OpenLDAP).
tigefa4u
referenced
this pull request
in tigefa4u/gitlabhq
Jul 20, 2019
Improve the wording of the PostgreSQL version Closes #422 See merge request gitlab-org/gitlab-development-kit!577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with compatibility with more LDAP providers as the implementation
doesn't depend on the exact names of the LDAP fields. The LDAP strategy
helps maps the attributes to the fields in the info object and we use the
info object to get the email and name.
This makes the LDAP auth compatible with most OpenLDAP servers as well.